feat(app/block-sdk): Implement v25 upgrade handler #7935
Conversation
temp update branch to latest osmo remove load-test modifications set lane block-space update block-sdk to latest release update go versions in gomod / work files update match handler docs nop process proposal nit
WalkthroughThis update ushers in a significant advancement in the application, integrating the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
C:x/epochs
T:build
C:app-wiring
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
I fixed some lingering issues with regards to E2E and the v24 -> v25 upgrade. See #7933 If you pull in those changes, that should also reduce the diff of this PR to what actually matters as well |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
There was a problem hiding this comment.
Actionable comments posted: 2
Actionable comments outside the diff hunks (3)
CHANGELOG.md (3)
Line range hint
584-584: Avoid using bare URLs. Provide descriptive text for the hyperlink.- * [#7935](https://github.com/osmosis-labs/osmosis/pull/7935) Add block sdk and top of block auction from skip-mev + * [#7935](https://github.com/osmosis-labs/osmosis/pull/7935) Add block sdk and top of block auction from skip-mev. [View Pull Request](https://github.com/osmosis-labs/osmosis/pull/7935)
Line range hint
642-642: Avoid using bare URLs. Provide descriptive text for the hyperlink.- * [#7935](https://github.com/osmosis-labs/osmosis/pull/7935) Add block sdk and top of block auction from skip-mev + * [#7935](https://github.com/osmosis-labs/osmosis/pull/7935) Add block sdk and top of block auction from skip-mev. [View Pull Request](https://github.com/osmosis-labs/osmosis/pull/7935)
Line range hint
1223-1223: Ensure there are no empty links in the document.- * [#7935](https://github.com/osmosis-labs/osmosis/pull/7935) Add block sdk and top of block auction from skip-mev + * [#7935](https://github.com/osmosis-labs/osmosis/pull/7935) Add block sdk and top of block auction from skip-mev. [View Pull Request](https://github.com/osmosis-labs/osmosis/pull/7935)
There was a problem hiding this comment.
Actionable comments posted: 0
Actionable comments outside the diff hunks (9)
CHANGELOG.md (9)
Line range hint
325-325: Correct the punctuation in the heading.- ### State Breaking: + ### State Breaking
Line range hint
986-986: Ensure heading levels increment by one level at a time.- #### Features + ### Features
Line range hint
998-998: Ensure heading levels increment by one level at a time.- #### Minor improvements & Bug Fixes + ### Minor improvements & Bug Fixes
Line range hint
1007-1007: Ensure heading levels increment by one level at a time.- #### SDK fork updates + ### SDK fork updates
Line range hint
1012-1012: Ensure heading levels increment by one level at a time.- #### IAVL fork updates + ### IAVL fork updates
Line range hint
1064-1064: Ensure heading levels increment by one level at a time.- #### Features + ### Features
Line range hint
588-588: Wrap bare URLs in Markdown link syntax for better readability.- https://github.com/osmosis-labs/osmosis/releases/tag/v6.4.0 + [v6.4.0](https://github.com/osmosis-labs/osmosis/releases/tag/v6.4.0)
Line range hint
646-646: Wrap bare URLs in Markdown link syntax for better readability.- https://github.com/osmosis-labs/osmosis/releases/tag/v6.3.1 + [v6.3.1](https://github.com/osmosis-labs/osmosis/releases/tag/v6.3.1)
Line range hint
1227-1227: Ensure no empty links are present in the document.- [v6.1.0]() + [v6.1.0](https://github.com/osmosis-labs/osmosis/releases/tag/v6.1.0)
|
Our CI won't run as expected with this PR as it's base is not the osmosis base 😢 I've cannibalised this PR into this => #8058 Sorry, this is kinda annoying for you, and I don't mean to take your work, but the CI wasn't working, thanks for the PR is a massive help ❤️ |
In This PR
/app/upgrades/v25MinReserveFee- The minimum amount you need to outbid the highest bid (think of as a spam prevention)AuctionReserveFee- The minimum amount an address can bid (as ansdk.Coin)EscrowAddress- The address to which the auction revenue less proposer fee should goProposerFee- What % of auction revenue should go to a proposer (currently 20%)adds to this PR => skip-mev#2
🤜 🤛 From Skip!
In This PR
LaneMempoolwhich will be used as the app'sMempoolx/auctionmodule, and the correspondingAnteHandlerfor the auction moduleante.IgnoreDecoratorwith thefreeLane, and theDeductFeesante-handler: this will skip theDeductFeesante-handler for any txs that originate from thefreeLaneTesting
ante_no_seqante-handlers to ignore signature verification, while incrementing sequence #s, I leave a comment in the section describing why.Let's Discuss
Auctionmodule's parameters are here, take a look at these or we can go ahead w/ the defaults, some things to considerdistributiontypes.WithdrawDelegatorRewardstx, the process of adding more txs to this lane is simple, we just need to identify which types we want!Summary by CodeRabbit
Summary by CodeRabbit
E2E_UPGRADE_VERSIONfrom "v24" to "v25" across various configurations.